ci(bindings/cpp): cpp test framework#6296
Merged
Xuanwo merged 18 commits intoapache:mainfrom Aug 4, 2025
Merged
Conversation
asukaminato0721
changed the title
dosubot
bot
added
size:XXL
asukaminato0721
force-pushed
the
cpp-test-framework
branch
from
bce2ff2 to
b16c703
Compare
asukaminato0721
force-pushed
the
cpp-test-framework
branch
from
b16c703 to
b8c2b07
Compare
Member
|
also cc @JackDrogon for a look. |
Contributor
|
It's a good work. |
Xuanwo
reviewed
Jul 12, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Contributor
|
@Xuanwo hh，add me as a reviewer |
Member
|
Hi, @asukaminato0721 thank you for working on this! I believe this PR is ready to go. Can you resolve the conflicts? |
Xuanwo
reviewed
Aug 3, 2025
Xuanwo
approved these changes
Aug 4, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @asukaminato0721 for working on this, really great!
Member
|
Hi @asukaminato0721, several C++ tests have failed. Could you take a look? Also, since you're now an OpenDAL committer, please submit PRs from the |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
similar to #3472 but for cpp.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?