Skip to content

Comments

feat(services/moka): expose more moka configurations#6285

Merged
Xuanwo merged 12 commits intomainfrom
expose-more-moka-config
Jun 17, 2025
Merged

feat(services/moka): expose more moka configurations#6285
Xuanwo merged 12 commits intomainfrom
expose-more-moka-config

Conversation

@koushiro
Copy link
Member

@koushiro koushiro commented Jun 12, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

Expose more moka configurations

What changes are included in this PR?

add configure method to modify the moka::future::CacheBuilder

Are there any user-facing changes?

@koushiro koushiro requested a review from Xuanwo as a code owner June 12, 2025 02:15
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Jun 12, 2025
@koushiro koushiro changed the title feat(services/moka): expose more moka configuraions feat(services/moka): expose more moka configurations Jun 13, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 13, 2025
@koushiro koushiro force-pushed the expose-more-moka-config branch from 0faee1d to 543174a Compare June 13, 2025 11:36
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 17, 2025
@koushiro koushiro force-pushed the expose-more-moka-config branch from 9d70f88 to 9c5917a Compare June 17, 2025 04:42
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2025
@Xuanwo Xuanwo merged commit 97514cd into main Jun 17, 2025
354 of 355 checks passed
@Xuanwo Xuanwo deleted the expose-more-moka-config branch June 17, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants