feat(core): Expose presign_xxx_options API#6273
Merged
Xuanwo merged 3 commits intoapache:mainfrom Jun 10, 2025
Merged
Conversation
Member
|
Thank you @geruh, that's really great work! Would you like to start an issue to track them? |
Xuanwo
reviewed
Jun 9, 2025
6 tasks
Xuanwo
approved these changes
Jun 10, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you, really love this change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related to: #6213
Rationale for this change
This PR extends the functionality introduced in #6215 by exposing
presign_xxx_optionsAPI methods, allowing users to pass detailed options when generating presigned URLs across all services supporting presign.What changes are included in this PR?
Users can now specify detailed options when presigning:
During testing, I was adding some tests to ensure that options were being set properly across the services for presigning, and I noticed some of the options aren't being set.
putoperations in the backend.reqsignalso doesn't support custom headers during SAS generation. This prevents implementing options like cache-control, content-disposition, and conditional headers without upstream reqsign library changes. Also, OpenDAL doesn't leverage reqsign's token generation and requires it to be manually passed in or the capability is disabled. hence, why testing doesn't pick this up.Today, the tests with limited support will fail, and it might be better to just omit these tests, keep the same behavior as today, and address each service in a separate PR.
Are there any user-facing changes?
No extending the functionality to be able to pass in options to all presigning operations
Manual testing
S3 passes & Azurite some passes