Conversation
koushiro
force-pushed
the
add-fastmetrics-layer
branch
from
575710f to
d675c9c
Compare
dosubot
bot
added
size:L
Xuanwo
approved these changes
Jun 10, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Add another metrics layer implementation
What changes are included in this PR?
fastmetrics is another OpenMetrics library I implemented.
Its implementation and APIs are referenced from prometheus_client and prometheus library, and it provides a convenient derive macro for registering metrics. It has been used in several of my own projects for a while, and I think it might be possible to push it into the OpenDAL repository.
Are there any user-facing changes?