refactor(core): Put Backtrace in a box to reduce error size#6193
Merged
refactor(core): Put Backtrace in a box to reduce error size#6193
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
xxchan
reviewed
May 16, 2025
|
|
||
| source: Option<anyhow::Error>, | ||
| backtrace: Backtrace, | ||
| backtrace: Option<Box<Backtrace>>, |
Member
There was a problem hiding this comment.
What about put everything except kind into a boxed inner struct?
Member
Author
There was a problem hiding this comment.
It's a tradeoff between "reducing the size from 88 to even smaller" and "always having a box allocation." I prefer to avoid the box allocation.
xxchan
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
This PR will address clippy issues around:
What changes are included in this PR?
This PR also fixed other clippy issues at the same time to make CI happy.
Are there any user-facing changes?