Skip to content

Comments

chore: remove useless labeler.yml#6192

Merged
Xuanwo merged 1 commit intomainfrom
remove-useless-labeler-file
May 16, 2025
Merged

chore: remove useless labeler.yml#6192
Xuanwo merged 1 commit intomainfrom
remove-useless-labeler-file

Conversation

@koushiro
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

In #5946, the ci_pr_labeler workflow was removed, but we forgot to delete the corresponding labeler.yml file.

What changes are included in this PR?

Are there any user-facing changes?

@koushiro koushiro requested a review from Xuanwo as a code owner May 16, 2025 05:55
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell labels May 16, 2025
@Xuanwo
Copy link
Member

Xuanwo commented May 16, 2025

Hi, we are relying on this file to generate release notes.

@koushiro
Copy link
Member Author

koushiro commented May 16, 2025

Hi, we are relying on this file to generate release notes.

We only rely on .github/release.yml and the labels of PRs to generate release notes.
And we use dosubot to add labels for PRs now, right? so I don't think the labeler.yml file is neccessary.
BTW, I also try to use dosubot to add PR labels in my project recently, and I can generate release notes without labeler.yml.

@Xuanwo
Copy link
Member

Xuanwo commented May 16, 2025

You are right on this.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 16, 2025
@Xuanwo Xuanwo merged commit 581f3b4 into main May 16, 2025
13 checks passed
@Xuanwo Xuanwo deleted the remove-useless-labeler-file branch May 16, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants