test(oli): introduce snapshot testing#6174
Merged
Xuanwo merged 2 commits intoapache:mainfrom May 13, 2025
Merged
Conversation
- combine integration test binaries into single binary. For faster compilation, and share test utils - introduce snapshot testing for tests that are easy to write and read Signed-off-by: xxchan <[email protected]>
dosubot
bot
added
the
size:XS
Signed-off-by: xxchan <[email protected]>
asukaminato0721
approved these changes
May 12, 2025
tisonkun
approved these changes
May 12, 2025
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
I'm feelig the test_utils out of structural, but it doesn't get worse so I'd approve this so that we can iterate more to find the way to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Mainly 2 forms:
assert_cmd_snapshot!: to snapshot the result of a cmdassert_cmd!with adirectory_snapshot: to snapshot the overview of a directoryAre there any user-facing changes?