refactor(bindings/java): deprecate append in favor of write with append=true#6169
Conversation
dosubot
bot
added
size:S
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
I'd suggest you remove the rust part code also, and actually you can remove these Java method as well with proper upgrade.md changelog.
kingsword09
force-pushed
the
refactor-asyncoperator-append-merge-into-write
branch
from
7e6be9b to
e5f145b
Compare
dosubot
bot
added
size:L
Thanks for the feedback! I've updated the PR according to your suggestions. |
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Great!
Generally looks good. IIRC you can do the same for the (blocking) Operator?
I checked the (blocking) Operator and it seems to have no standalone append method. |
Interesting. Thanks for looking into this. Then we should be good to merge. Merging ... |
tisonkun
changed the title
2 participants
Which issue does this PR close?
Closes #6163.
Rationale for this change
What changes are included in this PR?
The append methods have been deprecated and replaced with the write method using WriteOptions.builder().append(true).build().
Are there any user-facing changes?