Skip to content

Comments

fix(integrations/object_store): fix double percent encoding#6166

Merged
Xuanwo merged 1 commit intoapache:mainfrom
Colerar:fix-percent-encode
May 14, 2025
Merged

fix(integrations/object_store): fix double percent encoding#6166
Xuanwo merged 1 commit intoapache:mainfrom
Colerar:fix-percent-encode

Conversation

@Colerar
Copy link
Contributor

@Colerar Colerar commented May 10, 2025

Which issue does this PR close?

Closes #6129.

What changes are included in this PR?

Performing percent_decode_path in object-store-opendal before invoking inner operations

Are there any user-facing changes?

No

@Colerar Colerar requested a review from Xuanwo as a code owner May 10, 2025 15:29
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels May 10, 2025
@Colerar Colerar force-pushed the fix-percent-encode branch from 58936f7 to a1c373a Compare May 10, 2025 16:00
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 10, 2025
@Colerar Colerar force-pushed the fix-percent-encode branch from da5cd35 to a2e850a Compare May 10, 2025 16:12
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 10, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 14, 2025
@Xuanwo Xuanwo changed the title fix(integrations/object_store): fix double percent encoding (#6129) fix(integrations/object_store): fix double percent encoding May 14, 2025
@Xuanwo Xuanwo merged commit a4079ec into apache:main May 14, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: object_store path will be percent-encoded twice

2 participants