refactor(bindings/go): add ffiCall type for FFI function signature#6158
Merged
refactor(bindings/go): add ffiCall type for FFI function signature#6158
Conversation
Introduce a new type definition for the FFI function signature to improve code maintainability and readability. This change standardizes how FFI calls are handled across the codebase by replacing inline function signatures with a named type. Signed-off-by: Hanchin Hsieh <[email protected]>
dosubot
bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4892.
This PR:
Introduces a new type definition for the FFI function signature to enhance code maintainability and readability. This change standardizes FFI call handling across the codebase by replacing inline function signatures with a named type.
Enables all service tests for Go binding, which I believe is the final step needed to close new feature: Support more storage services and APIs for Go bindings. #5326, as all feature requests in this issue have been completed.