refactor(services/webhdfs): Refactor raw request send in writer and backend#6113
Merged
Xuanwo merged 2 commits intoapache:mainfrom Apr 28, 2025
Merged
refactor(services/webhdfs): Refactor raw request send in writer and backend#6113Xuanwo merged 2 commits intoapache:mainfrom
Xuanwo merged 2 commits intoapache:mainfrom
Conversation
jorgehermo9
commented
Apr 27, 2025
| self.info.http_client().send(req).await | ||
| } | ||
|
|
||
| pub async fn webhdfs_rename_object(&self, from: &str, to: &str) -> Result<Response<Buffer>> { |
Contributor
Author
There was a problem hiding this comment.
Moved the functions so webhdfs_init_append is next to webhdfs_append
jorgehermo9
commented
Apr 27, 2025
| } | ||
|
|
||
| fn webhdfs_open_request(&self, path: &str, range: &BytesRange) -> Result<Request<Buffer>> { | ||
| pub async fn webhdfs_list_status(&self, path: &str) -> Result<Response<Buffer>> { |
Contributor
Author
There was a problem hiding this comment.
As I moved the webhdfs_open_request to be next webhdfs_read_file, the diff seems to be broken and it appears that I changed a lot... But I just moved the webhdfs_open_request a few lines down :/
jorgehermo9
commented
Apr 27, 2025
| ) -> Result<Request<Buffer>> { | ||
| let mut url = location.to_string(); | ||
| ) -> Result<Response<Buffer>> { | ||
| let mut url = self.webhdfs_init_append(path).await?; |
Contributor
Author
There was a problem hiding this comment.
as webhdfs_init_append was only called just before webhdfs_append once, I moved it to be inside the webhdfs_append function
jorgehermo9
changed the title
dosubot
bot
added
size:L
Member
|
Please address the conflicts, thank you! |
Contributor
Author
|
Done @Xuanwo , thanks for the review! |
Contributor
Author
|
Mistakenly closed this, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now all
self.info.http_client().send(req).awaithappen incore.rs.This is the last one of these PRs, I swear!!