refactor(services/seafile): Refactor raw request send in writer and lister#6104
Merged
Xuanwo merged 3 commits intoapache:mainfrom Apr 27, 2025
Merged
refactor(services/seafile): Refactor raw request send in writer and lister#6104Xuanwo merged 3 commits intoapache:mainfrom
Xuanwo merged 3 commits intoapache:mainfrom
Conversation
jorgehermo9
commented
Apr 27, 2025
|
|
||
| pub struct ListResponse { | ||
| pub infos: Option<Vec<Info>>, | ||
| pub rooted_abs_path: String, |
Contributor
Author
There was a problem hiding this comment.
Have to return rooted_abs_path in list response because let rooted_abs_path = build_rooted_abs_path(&self.root, path); is called in core.rs list funcion, and we neet it also in lister.rs
The alternative is to duplicate let rooted_abs_path = build_rooted_abs_path(&self.root, path); in lister.rs, but I prefer to return it in the list response as done here
jorgehermo9
commented
Apr 27, 2025
| } | ||
|
|
||
| #[derive(Debug, Deserialize)] | ||
| pub struct Info { |
Contributor
Author
There was a problem hiding this comment.
Moved this from lister.rs to here
dosubot
bot
added
size:L
jorgehermo9
changed the title
Xuanwo
approved these changes
Apr 27, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @jorgehermo9 for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to work on #5774 we need all
Request::*calls incore.rs