refactor(services/azblob): Refactor raw request send in writer#6102
Merged
Xuanwo merged 2 commits intoapache:mainfrom Apr 27, 2025
Merged
refactor(services/azblob): Refactor raw request send in writer#6102Xuanwo merged 2 commits intoapache:mainfrom
Xuanwo merged 2 commits intoapache:mainfrom
Conversation
jorgehermo9
commented
Apr 27, 2025
| } | ||
|
|
||
| pub fn azblob_complete_put_block_list_request( | ||
| fn azblob_complete_put_block_list_request( |
Contributor
Author
There was a problem hiding this comment.
changed some internal functions to private visibility. Other *_request functions such as azblob_get_blob_request needs to be private because they're used to get presign urls in backend.rs
dosubot
bot
added
size:M
Xuanwo
approved these changes
Apr 27, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @jorgehermo9 for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored some write functions to be consistent with other functions in the service. For example:
https://github.com/jorgehermo9/opendal/blob/fc2d7a54eebe38cdb79a19420ce3a08e4a008461/core/src/services/azblob/writer.rs#L145