refactor(services/yandex_disk): Move raw request to core#6090
Merged
Xuanwo merged 9 commits intoapache:mainfrom Apr 27, 2025
Merged
refactor(services/yandex_disk): Move raw request to core#6090Xuanwo merged 9 commits intoapache:mainfrom
Xuanwo merged 9 commits intoapache:mainfrom
Conversation
jorgehermo9
commented
Apr 26, 2025
| } | ||
|
|
||
| async fn read(&self, path: &str, args: OpRead) -> Result<(RpRead, Self::Reader)> { | ||
| // TODO: move this out of reader. |
Contributor
Author
There was a problem hiding this comment.
Is it okay to remove this TODO? Is this addressed now? I see the get_download_url and download(download_url) pattern in few backend.rs and it think it is the recommended approach, right? Or should we move both get_download_url and download(download_url) into a new read function inside core.rs so the backend is abstracted from this two-step flow?
Contributor
Author
There was a problem hiding this comment.
Oh, I see that b2 service encapsulates both download_url and download in core
opendal/core/src/services/b2/core.rs
Line 241 in 05dde6a
Should we do the same here?
Contributor
Author
There was a problem hiding this comment.
Per #6089 (comment), I will refactor this also
dosubot
bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6064 (comment)