Conversation
Signed-off-by: Xuanwo <[email protected]>
Contributor
|
fs on my side |
yihong0618
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
Use divan as opendal's benchmark framework which is easy to use and have nice output:
types fastest │ slowest │ median │ mean │ samples │ iters ├─ buffer │ │ │ │ │ │ ├─ advance │ │ │ │ │ │ │ ├─ bytes 0.214 ns │ 0.752 ns │ 0.231 ns │ 0.273 ns │ 100 │ 409600 │ │ ├─ contiguous 1.309 ns │ 8.037 ns │ 1.368 ns │ 1.692 ns │ 100 │ 204800 │ │ ╰─ non_contiguous │ │ │ │ │ │ │ ├─ 10 1.144 ns │ 2.219 ns │ 1.168 ns │ 1.294 ns │ 100 │ 204800 │ │ ├─ 1000 1.064 ns │ 1.97 ns │ 1.085 ns │ 1.119 ns │ 100 │ 204800 │ │ ╰─ 1000000 1.735 ns │ 3.164 ns │ 2.21 ns │ 2.262 ns │ 100 │ 102400 │ ├─ chunk │ │ │ │ │ │ │ ├─ bytes 0.002 ns │ 0.471 ns │ 0.002 ns │ 0.008 ns │ 100 │ 819200 │ │ ├─ contiguous 0.049 ns │ 0.341 ns │ 0.067 ns │ 0.08 ns │ 100 │ 819200 │ │ ╰─ non_contiguous │ │ │ │ │ │ │ ├─ 10 0.025 ns │ 0.869 ns │ 0.038 ns │ 0.086 ns │ 100 │ 409600 │ │ ├─ 1000 0.069 ns │ 0.7 ns │ 0.155 ns │ 0.194 ns │ 100 │ 409600 │ │ ╰─ 1000000 1.276 ns │ 3.496 ns │ 1.608 ns │ 1.676 ns │ 100 │ 102400 │ ├─ iterator │ │ │ │ │ │ │ ├─ contiguous 15.9 µs │ 44.93 µs │ 18.14 µs │ 19.59 µs │ 100 │ 200 │ │ ╰─ non_contiguous │ │ │ │ │ │ │ ├─ 10 16.9 µs │ 31.95 µs │ 17.53 µs │ 18.14 µs │ 100 │ 200 │ │ ├─ 1000 16.71 µs │ 36.21 µs │ 17.54 µs │ 18.88 µs │ 100 │ 200 │ │ ╰─ 1000000 17.42 µs │ 28.13 µs │ 18 µs │ 19.47 µs │ 100 │ 200 │ ╰─ truncate │ │ │ │ │ │ ├─ bytes 19.34 ns │ 35.23 ns │ 19.66 ns │ 20.35 ns │ 100 │ 12800 │ ├─ contiguous 19.89 ns │ 86.42 ns │ 28.27 ns │ 28.72 ns │ 100 │ 12800 │ ╰─ non_contiguous │ │ │ │ │ │ ├─ 10 19.41 ns │ 35.7 ns │ 29.29 ns │ 29.07 ns │ 100 │ 6400 │ ├─ 1000 21.3 ns │ 34.62 ns │ 21.77 ns │ 22.37 ns │ 100 │ 6400 │ ╰─ 1000000 35.85 ns │ 97.85 ns │ 59.02 ns │ 59.71 ns │ 100 │ 3200 ╰─ tasks │ │ │ │ │ ├─ baseline 261 ms │ 266.4 ms │ 263.9 ms │ 263.6 ms │ 100 │ 100 ╰─ concurrent │ │ │ │ │ ├─ 1 260 ms │ 265.3 ms │ 264 ms │ 263.6 ms │ 100 │ 100 ├─ 2 30.17 ms │ 43.3 ms │ 31.79 ms │ 32.46 ms │ 100 │ 100 ├─ 8 11.43 ms │ 14.84 ms │ 12.51 ms │ 13.04 ms │ 100 │ 100 ╰─ 32 5.339 ms │ 7.669 ms │ 6.334 ms │ 6.328 ms │ 100 │ 100What changes are included in this PR?
Use divan instead.
Are there any user-facing changes?
None.