Skip to content

Comments

refactor(layers/tracing): Ensure the entire async function been traced#6000

Merged
Xuanwo merged 2 commits intomainfrom
better-tracing
Apr 11, 2025
Merged

refactor(layers/tracing): Ensure the entire async function been traced#6000
Xuanwo merged 2 commits intomainfrom
better-tracing

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 10, 2025

Which issue does this PR close?

Closes #5999

Rationale for this change

image

What changes are included in this PR?

Implement tracing correctly.

Are there any user-facing changes?

Better DX.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. core releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Apr 10, 2025
@Xuanwo Xuanwo requested a review from dqhl76 April 11, 2025 01:29
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of this PR is #6000. Incredible milestone. 🚀 Let's go

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 11, 2025
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 11, 2025

Thank you @dqhl76 for the review!

@Xuanwo Xuanwo merged commit af4e62c into main Apr 11, 2025
285 checks passed
@Xuanwo Xuanwo deleted the better-tracing branch April 11, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve TracingLayer to provide better exprience

2 participants