Skip to content

Comments

feat(bindings/nodejs): add check in js#5996

Merged
Xuanwo merged 5 commits intoapache:mainfrom
asukaminato0721:js-check
Apr 10, 2025
Merged

feat(bindings/nodejs): add check in js#5996
Xuanwo merged 5 commits intoapache:mainfrom
asukaminato0721:js-check

Conversation

@asukaminato0721
Copy link
Contributor

Which issue does this PR close?

part of #5963 .

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@asukaminato0721 asukaminato0721 changed the title add js binding feat(bindings/nodejs): add check in js Apr 9, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review April 9, 2025 15:57
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bindings/nodejs releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Apr 9, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asukaminato0721 for this.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2025
@Xuanwo Xuanwo merged commit a706499 into apache:main Apr 10, 2025
66 checks passed
@asukaminato0721 asukaminato0721 deleted the js-check branch April 10, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bindings/nodejs lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants