Skip to content

Comments

chore(services/s3): Use QueryPairsWriter for url write#5977

Merged
Xuanwo merged 1 commit intomainfrom
query-pairs
Apr 7, 2025
Merged

chore(services/s3): Use QueryPairsWriter for url write#5977
Xuanwo merged 1 commit intomainfrom
query-pairs

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 7, 2025

Which issue does this PR close?

Part of #5976

Rationale for this change

  • Improve performance of list objects (a bit)
  • Make code more readable and maintainable.

What changes are included in this PR?

Are there any user-facing changes?

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. core services/s3 labels Apr 7, 2025
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 7, 2025

Thank you @meteorgan for the review.

@Xuanwo Xuanwo merged commit 5a50ac4 into main Apr 7, 2025
102 checks passed
@Xuanwo Xuanwo deleted the query-pairs branch April 7, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core services/s3 size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants