Skip to content

Comments

feat(gridfs): implement GridfsCore for GridFS service#5966

Merged
Xuanwo merged 2 commits intoapache:mainfrom
uruemu:split-GridFS-core
Apr 7, 2025
Merged

feat(gridfs): implement GridfsCore for GridFS service#5966
Xuanwo merged 2 commits intoapache:mainfrom
uruemu:split-GridFS-core

Conversation

@uruemu
Copy link
Contributor

@uruemu uruemu commented Apr 5, 2025

Which issue does this PR close?

Addresses #5702: Split service logic to backend and core modules

Part of #5702.

Rationale for this change

What changes are included in this PR?

This pull request refactors the GridFsBackend by introducing a new GridFsBackendCore struct to hosting connection functionality and state. GridFsCore implements the kv::Adapters trait, allowing the removal of the Adapter struct

Are there any user-facing changes?

@uruemu uruemu requested a review from Xuanwo as a code owner April 5, 2025 23:29
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. core releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Apr 5, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 7, 2025
@Xuanwo Xuanwo merged commit 55ad613 into apache:main Apr 7, 2025
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants