refactor(core/types)!: fix with_user_metadata signature#5960
Merged
Conversation
meteorgan
changed the title
with_user_metadata to set_user_metadata
dosubot
bot
added
size:S
Xuanwo
reviewed
Apr 5, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Nice catch. However, since either change is a breaking change, we'll hold off on this PR for now until we're ready for the next major release.
meteorgan
force-pushed
the
fix-set-user-metadata
branch
from
40043c3 to
44f2524
Compare
meteorgan
changed the title
with_user_metadata to set_user_metadatawith_user_metadata signature
Member
|
Thank you @meteorgan for this! I have marked this as |
Member
|
We are ready to go! |
Xuanwo
approved these changes
May 21, 2025
Xuanwo
changed the title
with_user_metadata signaturewith_user_metadata signature
Xuanwo
removed
services/azblob
services/gcs
services/obs
services/oss
services/s3
labels
Xuanwo
added
releases-note/refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
Currently, the method signature of
with_user_metadatain the metadata module has a different signature to thewith_xxxmethods, which is a bit confusing.What changes are included in this PR?
Are there any user-facing changes?
None