Skip to content

Comments

feat(services/azblob): implement write returns metadata#5958

Merged
Xuanwo merged 3 commits intomainfrom
azblob_write_returns_metadata
Apr 6, 2025
Merged

feat(services/azblob): implement write returns metadata#5958
Xuanwo merged 3 commits intomainfrom
azblob_write_returns_metadata

Conversation

@meteorgan
Copy link
Contributor

Which issue does this PR close?

Part of #5693

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@meteorgan meteorgan marked this pull request as ready for review April 5, 2025 11:27
@meteorgan meteorgan requested a review from Xuanwo as a code owner April 5, 2025 11:27
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request services/azblob labels Apr 5, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most LGTM, thank you!

@meteorgan meteorgan force-pushed the azblob_write_returns_metadata branch from 9377378 to 3ad46da Compare April 5, 2025 15:24
@meteorgan meteorgan force-pushed the azblob_write_returns_metadata branch from 3ad46da to 02139e1 Compare April 5, 2025 15:45
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 6, 2025
@Xuanwo Xuanwo merged commit deee671 into main Apr 6, 2025
92 checks passed
@Xuanwo Xuanwo deleted the azblob_write_returns_metadata branch April 6, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer services/azblob size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants