refactor(ftp): restructure FtpBackend and introduce FtpCore#5949
Merged
Xuanwo merged 3 commits intoapache:mainfrom Apr 6, 2025
Merged
refactor(ftp): restructure FtpBackend and introduce FtpCore#5949Xuanwo merged 3 commits intoapache:mainfrom
Xuanwo merged 3 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:L
uruemu
force-pushed
the
split-ftp-core
branch
2 times, most recently
from
989f2e1 to
df03438
Compare
erickguan
reviewed
Apr 3, 2025
Member
erickguan
left a comment
erickguan
left a comment
There was a problem hiding this comment.
Thanks for your contribution, Uruemu! Love this.
I have one comment on how the core establishes connections.
| password: String, | ||
| enable_secure: bool, | ||
| pool: OnceCell<bb8::Pool<Manager>>, | ||
| core: Arc<FtpCore>, |
erickguan
approved these changes
Apr 5, 2025
Member
erickguan
left a comment
erickguan
left a comment
There was a problem hiding this comment.
Thank you very much. This looks good to me!
Contributor
Author
|
Thanks @erickguan for the review and suggestions. Is this good to merge right away after approval or are there any other prerequisites? |
Member
|
@uruemu The last thing is to fix errors from CI. For example, running clippy: |
Contributor
Author
|
@erickguan Fixed the errors. Ready to merge |
Member
|
Thank you @uruemu for the work and @erickguan for the review. Let's move! |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Addresses #5702: Split service logic to
backendandcoremodulesRationale for this change
What changes are included in this PR?
This pull request refactors the
FtpBackendby introducing a newFtpCorestruct to hosting connection functionality and state.Are there any user-facing changes?