Merged
Conversation
Signed-off-by: Mingzhuo Yin <[email protected]>
dosubot
bot
added
the
size:XS
github-actions
bot
added
the
releases-note/chore
Member
|
Thank you @silver-ymz for this! I used to think we have tested our examples but it seems not? Is this a good time for us to include them in CI? |
Member
Author
|
There have been some changes to the API. But we haven't updated the API version for examples before. #5907 updates it and showes us the error. We can update CI to include examples. |
Iam-WenYi
approved these changes
Apr 3, 2025
Iam-WenYi
left a comment
Iam-WenYi
left a comment
There was a problem hiding this comment.
OK, the problem is solved, thanks very much!
Member
Author
|
@Xuanwo Could we merge this PR first and setup CI for cpp examples in another PR? |
tisonkun
approved these changes
Apr 4, 2025
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5942
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?