Skip to content

Comments

refactor: Migrate icloud service to context based http client#5891

Merged
Xuanwo merged 1 commit intoapache:mainfrom
miroim:migrate-icloud-context
Mar 27, 2025
Merged

refactor: Migrate icloud service to context based http client#5891
Xuanwo merged 1 commit intoapache:mainfrom
miroim:migrate-icloud-context

Conversation

@miroim
Copy link
Member

@miroim miroim commented Mar 27, 2025

Which issue does this PR close?

Part of #5677

Rationale for this change

What changes are included in this PR?

  • Added info field to IcloudSigner and IcloudCore , updated methods to use AccessorInfo for HTTP requests.

Are there any user-facing changes?

@miroim miroim requested a review from Xuanwo as a code owner March 27, 2025 03:11
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Mar 27, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @miroim, really love this!

@Xuanwo Xuanwo merged commit 7047ec3 into apache:main Mar 27, 2025
242 checks passed
@miroim miroim deleted the migrate-icloud-context branch March 27, 2025 03:55
@Xuanwo Xuanwo mentioned this pull request Mar 27, 2025
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants