Skip to content

Comments

refactor: Migrate http service to context based http client#5879

Merged
Xuanwo merged 2 commits intoapache:mainfrom
miroim:introduce-http-core
Mar 26, 2025
Merged

refactor: Migrate http service to context based http client#5879
Xuanwo merged 2 commits intoapache:mainfrom
miroim:introduce-http-core

Conversation

@miroim
Copy link
Member

@miroim miroim commented Mar 26, 2025

Which issue does this PR close?

Part of #5677
Part of #5702

Rationale for this change

What changes are included in this PR?

  • This pull request refactors the HttpBackend by introducing a new HttpCore struct to encapsulate the core functionality and state. The changes aim to improve code organization and maintainability.
  • Use the http_client from AccessorInfo, instead of directly accessing the backend, to migrate the service to a context-based http client.

Are there any user-facing changes?

@miroim miroim requested a review from Xuanwo as a code owner March 26, 2025 02:22
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Mar 26, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Xuanwo Xuanwo merged commit 2282db5 into apache:main Mar 26, 2025
242 checks passed
@miroim miroim deleted the introduce-http-core branch March 26, 2025 05:30
@Xuanwo Xuanwo mentioned this pull request Mar 27, 2025
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants