Skip to content

Comments

refactor: migrate azblob services to context based http client#5845

Merged
Xuanwo merged 2 commits intoapache:mainfrom
Ziy1-Tan:azblob_ctx
Mar 23, 2025
Merged

refactor: migrate azblob services to context based http client#5845
Xuanwo merged 2 commits intoapache:mainfrom
Ziy1-Tan:azblob_ctx

Conversation

@Ziy1-Tan
Copy link
Contributor

@Ziy1-Tan Ziy1-Tan commented Mar 21, 2025

Which issue does this PR close?

Closes #5480 .

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Ziy1-Tan Ziy1-Tan requested a review from Xuanwo as a code owner March 21, 2025 13:39
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Mar 21, 2025
@Xuanwo
Copy link
Member

Xuanwo commented Mar 22, 2025

Build failed for:

error[E0560]: struct `azblob::core::AzblobCore` has no field named `client`
   --> /home/runner/work/opendal/opendal/core/src/services/ghac/writer.rs:130:21
    |
130 |                     client: core.http_client.clone(),
    |                     ^^^^^^ `azblob::core::AzblobCore` does not have this field
    |
    = note: all struct fields are already assigned

Please note that ghac depends on azblob.

Xuanwo
Xuanwo approved these changes Mar 23, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@Xuanwo Xuanwo merged commit e4ffcdd into apache:main Mar 23, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issues of RFC-5479: Context

2 participants

@Ziy1-Tan @Xuanwo