refactor(core): Migrate BlockWriter to use executor from context#5834
Merged
refactor(core): Migrate BlockWriter to use executor from context#5834
Conversation
Signed-off-by: Xuanwo <[email protected]>
github-actions
bot
added
the
releases-note/refactor
meteorgan
approved these changes
Mar 20, 2025
Contributor
meteorgan
left a comment
meteorgan
left a comment
There was a problem hiding this comment.
LGTM. Thank you for working on this.
Member
Author
|
Thank you @meteorgan for the review, I will have some similiars PRs to come. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5831
Rationale for this change
Migrate BlockWriter to use executor from context so that users can inject context in executor instead.
What changes are included in this PR?
Migrate BlockWriter to use executor from context
Are there any user-facing changes?
No.