Skip to content

Comments

feat(core): Implement http related metrics support for prom client#5798

Merged
Xuanwo merged 1 commit intomainfrom
http-metrics
Mar 18, 2025
Merged

feat(core): Implement http related metrics support for prom client#5798
Xuanwo merged 1 commit intomainfrom
http-metrics

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 18, 2025

Which issue does this PR close?

Part of #5794

Rationale for this change

See #5794

What changes are included in this PR?

  • Add http related metrics for observe::MetricsLayer
  • Implement for PrometheusClientLayer

Are there any user-facing changes?

New APIs for PrometheusClientLayerBuilder to configure http metrics.

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Mar 18, 2025
Copy link
Member

@koushiro koushiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 18, 2025

Thank you @koushiro for the review!

@Xuanwo Xuanwo merged commit 126b5d6 into main Mar 18, 2025
283 checks passed
@Xuanwo Xuanwo deleted the http-metrics branch March 18, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants