feat: Add origin private file system scaffold#5758
feat: Add origin private file system scaffold#5758Xuanwo merged 6 commits intoapache:mainfrom Eason0729:opfs
Conversation
|
Thank you for your review(and I missing it earlier). I will address your suggestions tomorrow. |
core/src/services/opfs/backend.rs
Outdated
|
|
||
| impl Debug for OpfsConfig { | ||
| fn fmt(&self, _f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| panic!() |
There was a problem hiding this comment.
We can derive it instead of panic.
core/src/services/opfs/backend.rs
Outdated
|
|
||
| impl OpfsBuilder {} | ||
|
|
||
| impl Debug for OpfsBuilder { |
core/src/services/opfs/backend.rs
Outdated
| type BlockingDeleter = (); | ||
|
|
||
| fn info(&self) -> Arc<AccessorInfo> { | ||
| todo!() |
There was a problem hiding this comment.
Let's provide a default AccessorInfo instead.
core/src/services/opfs/error.rs
Outdated
| use crate::Error; | ||
| use crate::ErrorKind; | ||
|
|
||
| impl From<JsValue> for Error { |
There was a problem hiding this comment.
Hi, please implement parse_js_error instead to avoid leak this public API to users.
core/src/services/mod.rs
Outdated
| mod onedrive; | ||
| pub use onedrive::*; | ||
|
|
||
| mod opfs; |
There was a problem hiding this comment.
Maybe we need to gate this under cfg(wasm32)?
|
Hi, @Eason0729, to get this PR merged, we will need:
|
|
@Xuanwo, thanks for the feedback. I've just fixed those issues so that:
Please let me know if there's anything else needed! |
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Other LGTM, thank you for this good start.
Xuanwo
changed the title
github-actions
bot
added
the
releases-note/feat
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @Eason0729 for working on this!
2 participants
Which issue does this PR close?
close #2442
Rationale for this change
What changes are included in this PR?
read/write support for OPFS
Are there any user-facing changes?