refactor(services/redis): Implement ConnectionLike for RedisConnection#5748
Merged
refactor(services/redis): Implement ConnectionLike for RedisConnection#5748
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
github-actions
bot
added
the
releases-note/refactor
tisonkun
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5739
Rationale for this change
I want to work on #5739, but I noticed that the redis service itself has several areas that need improvement first. In this PR, I will refactor those aspects before proceeding with the migration.
What changes are included in this PR?
We used to duplicate every commends which is not scale. I implement
ConnectionLikefor ourRedisConnectionso that we don't need to do this again.Are there any user-facing changes?
No.