ci: add clippy to some of the binding check ci#5717
Merged
Xuanwo merged 5 commits intoapache:mainfrom Mar 9, 2025
Merged
Conversation
Signed-off-by: yihong0618 <[email protected]>
yihong0618
requested review from
Xuanwo,
oowl,
suyanhanx and
xyjixyjixyji
as code owners
github-actions
bot
added
the
releases-note/ci
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
oowl
previously requested changes
Mar 9, 2025
Signed-off-by: yihong0618 <[email protected]>
Xuanwo
approved these changes
Mar 9, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @yihong0618, really love this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow the comment in #5708 (review)
this patch add clippy to some of the bindings
and make the clippy happy of them
Also found some api had changed for them, this patch does not change them instead of add
FIXMEcommentfor later discuss or fix
update, the comment drop maybe fix them later