fix: bring back services ftp for python/java/node#5716
fix: bring back services ftp for python/java/node#5716yihong0618 wants to merge 9 commits intoapache:mainfrom
Conversation
Signed-off-by: yihong0618 <[email protected]>
yihong0618
requested review from
Zheaoli,
messense,
suyanhanx and
tisonkun
as code owners
github-actions
bot
added
the
releases-note/fix
|
And it might be a breaking change, if merge doc things is needed I think |
|
I have initiated a discussion upstream: veeso/suppaftp#100 I'm a bit concerned about relying on |
|
Hi， @yihong0618， the upstream fixed veeso/suppaftp#100, maybe you wanna try upgrade suppaftp and test if everything works as expected? |
will try this tonight |
Signed-off-by: yihong0618 <[email protected]>
|
Chore the dep but the |
core/src/services/ftp/backend.rs
Outdated
| // Create a root certificate store | ||
| let root_store = RootCertStore::empty(); | ||
| // Optionally, add certificates (e.g., system certs or custom ones) | ||
| // For now, we'll leave it empty as an example |
There was a problem hiding this comment.
I'm guessing we need to add system credentials at the very least?
There was a problem hiding this comment.
seems no need follow the old default will change the comment
|
Note that pulling in aws-lc-rs which uses |
will take a look |
|
Hi, @yihong0618, I'm open to merge the ftp SSL setup part. But I shared the same concern with @messense about enabling ftp by default. Would you like to change this PR to only include the first part? |
|
copy will do it tonight or tomorrow |
Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
after merge main and fix the conflict seems this patch is no need |
dosubot
bot
added
the
size:XS
Perfect! |
|
after merging seems only open ftp is needed so |
|
Thank you @yihong0618 for working on this. |
3 participants
Which issue does this PR close?
This path bring back services-ftp for java/node/python binding.
this feature comment in #3659
since issue #4090
and fixed in async-rs/async-tls#55 and #4091
I wonder they can be reopen again cc @messense