Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
github-actions
bot
added
the
releases-note/feat
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
| } | ||
| } | ||
|
|
||
| /// Get service's full capabilities. |
There was a problem hiding this comment.
Thanks for pointing that out. I'll fix it in my next PR.
| use reqsign::AzureStorageCredential; | ||
| use reqsign::AzureStorageLoader; | ||
| use reqsign::AzureStorageSigner; | ||
| use std::fmt; |
There was a problem hiding this comment.
maybe we should enable group_imports = "StdExternalCrate" in rustfmt.toml? although this only works with nightly, we can use cargo +nightly fmt -- --check when developing locally and still use cargo fmt -- --check in CI, wdyt?
There was a problem hiding this comment.
I prefer not to introduce unnecessary complexity into our development workflow, even if it adds some burden to our code.
However, feel free to propose a discussion on this—I’m open to feedback from the community.
koushiro
left a comment
koushiro
left a comment
There was a problem hiding this comment.
Thanks for doing this, a lot of dirty work 🤣
|
BTW, I think we can close #4896 once we merge this PR. |
2 participants
Signed-off-by: Xuanwo [email protected]
Which issue does this PR close?
Part of #5480
Rationale for this change
Prepare for using context's http client.
What changes are included in this PR?
Are there any user-facing changes?