Skip to content

Comments

fix(services/gdrive): skip the trailing slash when creating and querying the directory#5631

Merged
Xuanwo merged 1 commit intoapache:mainfrom
meteorgan:fix-gdrive-path
Feb 17, 2025
Merged

fix(services/gdrive): skip the trailing slash when creating and querying the directory#5631
Xuanwo merged 1 commit intoapache:mainfrom
meteorgan:fix-gdrive-path

Conversation

@meteorgan
Copy link
Contributor

Which issue does this PR close?

Closes #5615.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Feb 15, 2025
@meteorgan
Copy link
Contributor Author

There is a minor issue: we can't create a directory with a trailing slash, even though this is supported by gdrive

@meteorgan meteorgan marked this pull request as ready for review February 15, 2025 12:44
@meteorgan meteorgan requested a review from Xuanwo as a code owner February 15, 2025 12:44
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for the fix.

@Xuanwo Xuanwo merged commit 6cbaf6c into apache:main Feb 17, 2025
243 checks passed
@meteorgan meteorgan deleted the fix-gdrive-path branch February 17, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: When using gdrive as the schema, create_dir is not working properly

2 participants