feat(services/swift): Added user metadata support for swift service#5601
Merged
Xuanwo merged 15 commits intoapache:mainfrom Feb 10, 2025
Merged
feat(services/swift): Added user metadata support for swift service#5601Xuanwo merged 15 commits intoapache:mainfrom
Xuanwo merged 15 commits intoapache:mainfrom
Conversation
github-actions
bot
added
the
releases-note/feat
Member
|
Xuanwo
reviewed
Feb 7, 2025
Contributor
Author
|
@Xuanwo CI passed. PTAL |
Xuanwo
reviewed
Feb 10, 2025
Member
There was a problem hiding this comment.
Hi, please don't touch unrelated files.
core/src/services/swift/backend.rs
Outdated
|
|
||
| async fn stat(&self, path: &str, _args: OpStat) -> Result<RpStat> { | ||
| let resp = self.core.swift_get_metadata(path).await?; | ||
| debug!( |
Member
There was a problem hiding this comment.
Please remove debug lins like this.
core/src/services/swift/backend.rs
Outdated
| let meta = parse_into_metadata(path, resp.headers())?; | ||
| let headers = resp.headers(); | ||
| let mut meta = parse_into_metadata(path, headers)?; | ||
| // 添加日志：记录解析前的原始头部 |
core/src/services/swift/core.rs
Outdated
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| use log::debug; |
Member
There was a problem hiding this comment.
Please don't add debug links in services.
added 2 commits
February 10, 2025 20:26
Xuanwo
approved these changes
Feb 10, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @zhaohaidao for working on this!
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes swift service task for #4842
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?