feat(bindings/dart): Add dart binding#5591
Merged
Xuanwo merged 34 commits intoapache:mainfrom Mar 10, 2025
Merged
Conversation
asukaminato0721
changed the title
github-actions
bot
added
the
releases-note/feat
asukaminato0721
force-pushed
the
dart-binding
branch
from
3c3e299 to
4c71c47
Compare
Contributor
Author
|
I only ported part of the apis so the test can pass. And currently all result is using unwrap (as a first version). |
asukaminato0721
force-pushed
the
dart-binding
branch
from
17b22c8 to
4cdbabe
Compare
Member
|
Thank you so much, @asukaminato0721, for working on this. I will start reviewing this PR later next week. Wishing you a wonderful holiday in the meantime! |
asukaminato0721
force-pushed
the
dart-binding
branch
from
4cdbabe to
c795426
Compare
Xuanwo
reviewed
Feb 8, 2025
Xuanwo
reviewed
Feb 10, 2025
Contributor
Author
|
@Xuanwo now it's like drop-in replacement. await RustLib.init();
final File = FileManager.initOp(...);
// just add above 2 lines
final f = File("foo.txt"); |
asukaminato0721
force-pushed
the
dart-binding
branch
2 times, most recently
from
96e0456 to
d25bb41
Compare
asukaminato0721
force-pushed
the
dart-binding
branch
from
d25bb41 to
2f12f90
Compare
Xuanwo
approved these changes
Mar 10, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @asukaminato0721 for working on this!
Member
|
Hi, @asukaminato0721 would you like to create a tracking issue for the following tasks? I think we need examples, tests, docs and figure how to release it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2435. Use the same way as https://github.com/open-spaced-repetition/fsrs-rs-dart.
Rationale for this change
What changes are included in this PR?
add dart binding
Are there any user-facing changes?
no