feat(bindings/ruby): add operator info#5584
Merged
Xuanwo merged 1 commit intoapache:mainfrom Mar 3, 2025
erickguan:ruby-binding-opinfo
Merged
feat(bindings/ruby): add operator info#5584Xuanwo merged 1 commit intoapache:mainfrom erickguan:ruby-binding-opinfo
Xuanwo merged 1 commit intoapache:mainfrom
erickguan:ruby-binding-opinfo
Conversation
Xuanwo
reviewed
Mar 3, 2025
bindings/ruby/src/operator_info.rs
Outdated
| class.define_method("root", method!(OperatorInfo::root, 0))?; | ||
| class.define_method("name", method!(OperatorInfo::name, 0))?; | ||
| class.define_method("full_capability", method!(OperatorInfo::full_capability, 0))?; | ||
| class.define_method( |
Member
There was a problem hiding this comment.
Hi, maybe we can just expose full_capability as capability? native_capability seems meaningless to ruby users.
Xuanwo
approved these changes
Mar 3, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @erickguan for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5227
What changes are included in this PR?
Add
OperatorInfo.Are there any user-facing changes?
No
Question
I want to expose what configured layers are in an operator. Is there an API or issue about it? This is not useful in Rust core but is convenient for Python/Ruby users.