Skip to content

Comments

feat(bindings/ruby): add operator info#5584

Merged
Xuanwo merged 1 commit intoapache:mainfrom
erickguan:ruby-binding-opinfo
Mar 3, 2025
Merged

feat(bindings/ruby): add operator info#5584
Xuanwo merged 1 commit intoapache:mainfrom
erickguan:ruby-binding-opinfo

Conversation

@erickguan
Copy link
Member

Which issue does this PR close?

Part of #5227

What changes are included in this PR?

Add OperatorInfo.

Are there any user-facing changes?

No

Question

I want to expose what configured layers are in an operator. Is there an API or issue about it? This is not useful in Rust core but is convenient for Python/Ruby users.

@erickguan erickguan requested a review from PsiACE as a code owner January 31, 2025 21:43
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jan 31, 2025
class.define_method("root", method!(OperatorInfo::root, 0))?;
class.define_method("name", method!(OperatorInfo::name, 0))?;
class.define_method("full_capability", method!(OperatorInfo::full_capability, 0))?;
class.define_method(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, maybe we can just expose full_capability as capability? native_capability seems meaningless to ruby users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@erickguan erickguan requested a review from Xuanwo March 3, 2025 15:02
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @erickguan for this!

@Xuanwo Xuanwo merged commit 6833a10 into apache:main Mar 3, 2025
36 checks passed
@erickguan erickguan deleted the ruby-binding-opinfo branch March 3, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants