Skip to content

Comments

chore: try use logforth #5573

Merged
tisonkun merged 2 commits intomainfrom
use-logforth
Jan 27, 2025
Merged

chore: try use logforth #5573
tisonkun merged 2 commits intomainfrom
use-logforth

Conversation

@tisonkun
Copy link
Member

Somehow self-promoted. More affinity to the log crate.

@tisonkun tisonkun requested a review from Xuanwo as a code owner January 26, 2025 06:34
@github-actions github-actions bot added the releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell label Jan 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #5573 will not alter performance

Comparing use-logforth (2c13830) with main (cdbcc0f)

Summary

✅ 73 untouched benchmarks

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tisonkun for this. I'm open to this change as long as it not touching core/src.

@tisonkun
Copy link
Member Author

it not touching core/src

Yeah. I reviewed that and notice there is already a tracing dependencies for the layer and I think no need so far to make changes there.

@tisonkun tisonkun merged commit c6fe050 into main Jan 27, 2025
278 checks passed
@tisonkun tisonkun deleted the use-logforth branch January 27, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants