Skip to content

Comments

docs(integration/object_store): add example for datafusion#5543

Merged
Xuanwo merged 4 commits intoapache:mainfrom
meteorgan:object_store_examples
Jan 15, 2025
Merged

docs(integration/object_store): add example for datafusion#5543
Xuanwo merged 4 commits intoapache:mainfrom
meteorgan:object_store_examples

Conversation

@meteorgan
Copy link
Contributor

@meteorgan meteorgan commented Jan 13, 2025

Which issue does this PR close?

Part of: #4599

Rationale for this change

What changes are included in this PR?

add an example to demonstrate querying data in a S3 bucket using DataFusion and object_store_opendal

Are there any user-facing changes?

@Xuanwo Xuanwo changed the title example(integration/object_store): add example for datafusion docs(integration/object_store): add example for datafusion Jan 13, 2025
@github-actions github-actions bot added the releases-note/docs The PR modifies docs related content or has a title that begins with "docs" label Jan 13, 2025
@meteorgan meteorgan marked this pull request as ready for review January 13, 2025 12:12
@Xuanwo
Copy link
Member

Xuanwo commented Jan 13, 2025

Hi, this example is excellent. Could we include it in the README to make it more visible?

@meteorgan
Copy link
Contributor Author

Hi, this example is excellent. Could we include it in the README to make it more visible?

Ok, I'll add it later.

@meteorgan
Copy link
Contributor Author

Forgot to attach the result of this example:
Xnip2025-01-13_19-58-49

Copy link

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it -- thank you @meteorgan (and @Xuanwo for the pointer)

let op = Operator::new(builder)
.map_err(|err| DataFusionError::External(Box::new(err)))?
.finish();
let store = object_store_opendal::OpendalStore::new(op);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this is very cool

@meteorgan meteorgan force-pushed the object_store_examples branch from 43704b5 to 45e0dde Compare January 14, 2025 16:26
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thank you @meteorgan

@Xuanwo Xuanwo merged commit a8b793b into apache:main Jan 15, 2025
34 checks passed
@meteorgan meteorgan deleted the object_store_examples branch January 15, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/docs The PR modifies docs related content or has a title that begins with "docs"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants