Skip to content

Comments

fix(serivces/gcs): Gcs doesn't support read with if_(un)modified_since#5537

Merged
Xuanwo merged 1 commit intomainfrom
gcs-not-support-if-modified
Jan 13, 2025
Merged

fix(serivces/gcs): Gcs doesn't support read with if_(un)modified_since#5537
Xuanwo merged 1 commit intomainfrom
gcs-not-support-if-modified

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 13, 2025

Which issue does this PR close?

Follow up of #5531

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Xuanwo Xuanwo requested review from dqhl76 and meteorgan January 13, 2025 04:29
@github-actions github-actions bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Jan 13, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2025

CodSpeed Performance Report

Merging #5537 will not alter performance

Comparing gcs-not-support-if-modified (a7c73b6) with main (f951963)

Summary

✅ 73 untouched benchmarks

Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit 85c3803 into main Jan 13, 2025
95 checks passed
@Xuanwo Xuanwo deleted the gcs-not-support-if-modified branch January 13, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants