fix(integrations/object_store) object_store_opendal now compiles on wasm32-unknown-unknown#5530
Merged
Xuanwo merged 3 commits intoapache:mainfrom Jan 10, 2025
Merged
fix(integrations/object_store) object_store_opendal now compiles on wasm32-unknown-unknown#5530Xuanwo merged 3 commits intoapache:mainfrom
object_store_opendal now compiles on wasm32-unknown-unknown#5530Xuanwo merged 3 commits intoapache:mainfrom
Conversation
XiangpengHao
changed the title
object_store_opendal now compiles on wasm32-unknown-unknownobject_store_opendal now compiles on wasm32-unknown-unknown
github-actions
bot
added
the
releases-note/fix
Xuanwo
approved these changes
Jan 10, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @XiangpengHao for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5525.
Rationale for this change
Now it should compile on
wasm32-unknown-unknownWhat changes are included in this PR?
Minor bug fix.
After getting more educated around the issue, I think we can make it work without changing object_store crate. This patch has minor adjustments to make it work for wasm32.
I added a minor doc to instruct wasm users to enable send_wrapper feature. I also disabled the default feature so that it compiles -- users can add their own opendal features in their Cargo.toml.
One of the future work is to probably add CI to make sure it always build on wasm32-unknown-unknown.
Are there any user-facing changes?
No