Skip to content

Comments

fix(services/s3): List with deleted should contain latest#5518

Merged
Xuanwo merged 4 commits intomainfrom
fix-list-with-deleted
Jan 7, 2025
Merged

fix(services/s3): List with deleted should contain latest#5518
Xuanwo merged 4 commits intomainfrom
fix-list-with-deleted

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 7, 2025

Which issue does this PR close?

Closes #5507

Rationale for this change

See #5507

What changes are included in this PR?

Make sure latest version is included.

Are there any user-facing changes?

@Xuanwo Xuanwo requested a review from meteorgan January 7, 2025 13:50
@github-actions github-actions bot added the releases-note/fix The PR fixes a bug or has a title that begins with "fix" label Jan 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #5518 will improve performances by 18.88%

Comparing fix-list-with-deleted (fa98026) with main (4fe235a)

Summary

⚡ 4 improvements
✅ 69 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-list-with-deleted Change
256 KiB * 1000k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 100k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 10k chunk 183.6 ns 154.4 ns +18.88%
256 KiB * 1k chunk 212.8 ns 183.6 ns +15.89%

@Xuanwo Xuanwo requested a review from meteorgan January 7, 2025 14:11
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 7, 2025

Hi, @meteorgan, please review again.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 7, 2025

Thank you @meteorgan for the review!

@Xuanwo Xuanwo merged commit b212297 into main Jan 7, 2025
276 checks passed
@Xuanwo Xuanwo deleted the fix-list-with-deleted branch January 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: the implement of list_with_deleted is not consistent with the RFC-5495

2 participants