feat(core): Implement list with deleted for s3 service#5498
Merged
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
github-actions
bot
added
the
releases-note/feat
CodSpeed Performance ReportMerging #5498 will improve performances by 18.88%Comparing Summary
Benchmarks breakdown
|
Signed-off-by: Xuanwo <[email protected]>
7 tasks
Signed-off-by: Xuanwo <[email protected]>
meteorgan
reviewed
Jan 2, 2025
| if let Some(etag) = version_object.etag { | ||
| meta.set_etag(&etag); | ||
| meta.set_content_md5(etag.trim_matches('"')); | ||
| if self.args.deleted() { |
Contributor
There was a problem hiding this comment.
Did I misunderstand something ? this implementation seems to differ from the RFC description:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5496
Rationale for this change
Implement the RFC we need.
What changes are included in this PR?
s3servicesAre there any user-facing changes?
Users can now list deleted files from s3 services.