Skip to content

Comments

refactor: Remove batch concept from opendal#5393

Merged
Xuanwo merged 3 commits intomainfrom
remove-batch
Dec 6, 2024
Merged

refactor: Remove batch concept from opendal#5393
Xuanwo merged 3 commits intomainfrom
remove-batch

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 5, 2024

Which issue does this PR close?

Part of #3922

Rationale for this change

Batch doesn't exist in opendal anymore.

What changes are included in this PR?

Remove batch capability.

Are there any user-facing changes?

batch capability has been removed.

@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Dec 5, 2024
Signed-off-by: Xuanwo <[email protected]>
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #5393 will degrade performances by 15.89%

Comparing remove-batch (dc5fb7c) with main (c77a07a)

Summary

⚡ 5 improvements
❌ 4 regressions
✅ 64 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-batch Change
buffer 256 KiB * 32 advance 660.6 ns 573.1 ns +15.27%
buffer 256 KiB * 4 advance 660.6 ns 573.1 ns +15.27%
buffer 4.00 MiB * 32 advance 660.6 ns 573.1 ns +15.27%
buffer 4.00 MiB * 4 advance 660.6 ns 573.1 ns +15.27%
256 KiB * 1000k chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 100k chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 10k chunk 154.4 ns 183.6 ns -15.89%
256 KiB * 1k chunk 183.6 ns 212.8 ns -13.71%
concurrent 4 411.7 µs 365.5 µs +12.63%

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 6, 2024

Thank you @WenyXu for the review!

@Xuanwo Xuanwo merged commit 43481f4 into main Dec 6, 2024
@Xuanwo Xuanwo deleted the remove-batch branch December 6, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants