Skip to content

Comments

refactor: Implement RFC-3911 Deleter API #5392

Merged
Xuanwo merged 18 commits intomainfrom
deleter
Dec 5, 2024
Merged

refactor: Implement RFC-3911 Deleter API #5392
Xuanwo merged 18 commits intomainfrom
deleter

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 5, 2024

Signed-off-by: Xuanwo [email protected]

Which issue does this PR close?

A big part of #3922

Rationale for this change

Implement RFC.

What changes are included in this PR?

This PR implements all needed things to unblock further development.

Are there any user-facing changes?

Enable users to remove a large stream of files.

@Xuanwo
Add delete API
fc071dd 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Save work
5eaeb62 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Save work
2c056c0 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Save work
936f419 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Build
0f7d6d2 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Build pass
c31c774 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Build pass
558b603 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Check pass
accaf94 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Make clippy happy
f3a1b0e 
Signed-off-by: Xuanwo <[email protected]>
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Dec 5, 2024
@Xuanwo Xuanwo mentioned this pull request Dec 5, 2024
Open
18 tasks
Xuanwo added 4 commits December 5, 2024 20:12
@Xuanwo
Fix use
0fe3679 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix
5d50cf2 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
fix abort
fdc3049 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Polish Sink
72e7e8a 
Signed-off-by: Xuanwo <[email protected]>
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5392 will degrade performances by 21.37%

Comparing deleter (6869a44) with main (f3bf1d4)

Summary

⚡ 8 improvements
❌ 1 regressions
✅ 64 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main deleter Change
⚡ buffer 256 KiB * 32 chunk 183.6 ns 125.3 ns +46.56%
⚡ buffer 256 KiB * 4 chunk 183.6 ns 125.3 ns +46.56%
⚡ buffer 4.00 MiB * 32 chunk 183.6 ns 125.3 ns +46.56%
⚡ buffer 4.00 MiB * 4 chunk 183.6 ns 125.3 ns +46.56%
⚡ 256 KiB * 1000k chunk 183.6 ns 154.4 ns +18.88%
⚡ 256 KiB * 100k chunk 183.6 ns 154.4 ns +18.88%
⚡ 256 KiB * 10k chunk 183.6 ns 154.4 ns +18.88%
⚡ 256 KiB * 1k chunk 212.8 ns 183.6 ns +15.89%
❌ concurrent 8 355.2 µs 451.7 µs -21.37%

Xuanwo added 2 commits December 5, 2024 21:51
@Xuanwo
Fix tests
d76585e 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix tests
c555b44 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested review from George-Miao and dqhl76 December 5, 2024 15:08
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 5, 2024

NOTEs to reviewer:

  • Most changes are related to Access API changes
  • Meaningful changes happened in operator.rs and delete.rs.

George-Miao
George-Miao reviewed Dec 5, 2024
View reviewed changes
core/src/types/operator/operator.rs Outdated
Ok(())
}

/// Delete an infallible iterator of paths.
Copy link
Contributor

@George-Miao George-Miao Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fallible?

Copy link
Member Author

@Xuanwo Xuanwo Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Xuanwo
Xuanwo commented Dec 5, 2024
View reviewed changes
Xuanwo
Xuanwo commented Dec 5, 2024
View reviewed changes
George-Miao
George-Miao approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the core part (under oio) and not any of the services or layers. I trust you on that.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 5, 2024

Thank you @George-Miao for the review!

@Xuanwo Xuanwo merged commit c77a07a into main Dec 5, 2024
@Xuanwo Xuanwo deleted the deleter branch December 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@George-Miao George-Miao George-Miao approved these changes

@dqhl76 dqhl76 Awaiting requested review from dqhl76

Assignees

No one assigned

Labels

releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Xuanwo @George-Miao