refactor(core)!: Remove not used cap write_multi_align_size#5322
Merged
refactor(core)!: Remove not used cap write_multi_align_size#5322
Conversation
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
requested review from
PsiACE,
Zheaoli,
messense,
suyanhanx and
tisonkun
as code owners
github-actions
bot
added
the
releases-note/refactor
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
changed the title
Signed-off-by: Xuanwo <[email protected]>
CodSpeed Performance ReportMerging #5322 will degrade performances by 18.88%Comparing Summary
Benchmarks breakdown
|
Signed-off-by: Xuanwo <[email protected]>
PsiACE
approved these changes
Nov 14, 2024
Member
Author
|
Thank you @PsiACE for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
write_multi_align_size is designed solely for gcs, but it's now never been used.
What changes are included in this PR?
Remove write_multi_align_size from capability.
Are there any user-facing changes?