Skip to content

Comments

feat(bindings/c): add writer operation for Bindings C and Go#5141

Merged
Xuanwo merged 5 commits intomainfrom
feat-c-binding-writer
Sep 25, 2024
Merged

feat(bindings/c): add writer operation for Bindings C and Go#5141
Xuanwo merged 5 commits intomainfrom
feat-c-binding-writer

Conversation

@yuchanns
Copy link
Member

@yuchanns yuchanns commented Sep 24, 2024 •
edited
Loading

part of #4892.

  • I changed the test service to fs for maximum full capabilities.
  • Use BlockWriter instead of StdWriter as StdWriter has a limitation of max capacity of buffer to write in for each write operation:

    opendal/core/src/types/blocking_write/std_writer.rs

    Line 42 in 7821d77

    buf: oio::FlexBuf::new(256 * 1024),
  • Fixed some behavior tests.

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Sep 24, 2024
@yuchanns yuchanns force-pushed the feat-c-binding-writer branch 6 times, most recently from df7ac7a to 5843349 Compare September 24, 2024 16:30
@Xuanwo Xuanwo requested a review from xyjixyjixyji September 24, 2024 16:34
@yuchanns yuchanns force-pushed the feat-c-binding-writer branch from 5843349 to 45357c3 Compare September 25, 2024 01:29
xyjixyjixyji
xyjixyjixyji approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the C part is well written. +1 for the C code.

@yuchanns yuchanns force-pushed the feat-c-binding-writer branch 7 times, most recently from 4fc7d5f to 59582c7 Compare September 25, 2024 05:52
@yuchanns yuchanns force-pushed the feat-c-binding-writer branch from f4a2948 to 1ab7ae1 Compare September 25, 2024 07:29
@yuchanns yuchanns mentioned this pull request Sep 25, 2024
Closed
26 tasks
@yuchanns yuchanns force-pushed the feat-c-binding-writer branch from 1ab7ae1 to 143805f Compare September 25, 2024 07:44
@yuchanns yuchanns marked this pull request as ready for review September 25, 2024 07:53
@yuchanns
Copy link
Member Author

yuchanns commented Sep 25, 2024

Ready for review

@yuchanns yuchanns removed the request for review from Xuanwo September 25, 2024 07:54
@yuchanns yuchanns requested review from Xuanwo and xyjixyjixyji and removed request for PsiACE September 25, 2024 07:54
Xuanwo
Xuanwo approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for building this @yuchanns, and thanks @xyjixyjixyji's review!

@Xuanwo Xuanwo merged commit 8c78dcf into main Sep 25, 2024
@Xuanwo Xuanwo deleted the feat-c-binding-writer branch September 25, 2024 09:01
@asukaminato0721 asukaminato0721 mentioned this pull request Mar 23, 2025
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji xyjixyjixyji is a code owner

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuchanns @Xuanwo @xyjixyjixyji