Hi, @yuchanns, would you like to take a review?

It failed at Setup Target.

3s
Run rustup target add $TARGET
error: error: the following required arguments were not provided:
  <target>...

IMO the pwsh doesn't support $TARGET, you can use $env:TARGET with a branch if: ${{ matrix.build.os == 'windows-latest' }}

While it comes to the step Build C Binding, you will need to modify the dynamic suffix too:

      - name: Build C Binding
        working-directory: bindings/c
        env:
          VERSION: "latest"
          SERVICE: ${{ matrix.service }}
          TARGET: ${{ matrix.build.target }}
          CC: ${{ matrix.build.cc }}
          OS: ${{ matrix.build.os }}
        run: |
          cargo build --target $TARGET  --release
          DIR=$GITHUB_WORKSPACE/libopendal_c_${VERSION}_${SERVICE}_$TARGET
          mkdir $DIR
          if [ ${OS} == 'ubuntu-latest' ]; then
            SO=so
         # Add SO=dll
          else
            SO=dylib
          fi

@yuchanns Thanks, I will test it in my Windows Computer :)

@yuchanns Any idea about this? I think I am close.

It compiles opendal_c.dll, instead of libopendal_c.dll

   Compiling opendal v0.51.1 (D:\a\opendal\opendal\core)
    Finished `release` profile [optimized] target(s) in 2m 21s

    Directory: D:\a\opendal\opendal

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----           1/13/2025  7:47 AM                libopendal_c_latest_fs_x86_64-pc-windows-msvc
zstd: can't stat ./target/x86_64-pc-windows-msvc/release/libopendal_c.dll : No such file or directory -- ignored 

I think renaming it should just works.

@yuchanns Sorry, can you give me some hint about this error?

Error: C:\Users\runneradmin\go\pkg\mod\github.com\apache\opendal-go-services\[email protected]\service.go:60:29: undefined: libopendalZst
# github.com/apache/opendal/bindings/go
Error: ..\..\ffi.go:32:28: undefined: purego.Dlopen
Error: ..\..\ffi.go:32:48: undefined: purego.RTLD_LAZY
Error: ..\..\ffi.go:32:65: undefined: purego.RTLD_GLOBAL
Error: ..\..\ffi.go:44:10: undefined: purego.Dlclose
Error: ..\..\ffi.go:86:21: undefined: purego.Dlsym
Error: ..\..\delete.go:58:25: undefined: unix.BytePtrFromString
Error: ..\..\operator.go:114:24: undefined: unix.BytePtrFromString
Error: ..\..\operator.go:1[80](https://github.com/apache/opendal/actions/runs/12747104741/job/35524528295?pr=5066#step:18:81):23: undefined: unix.BytePtrFromString
Error: ..\..\operator.go:184:25: undefined: unix.BytePtrFromString
Error: ..\..\operator_info.go:328:15: undefined: unix.BytePtrToString
Error: ..\..\operator_info.go:328:15: too many errors
FAIL	opendal_test [build failed]

Oops! That's an arch issue. Something needs to be solved in the go-services repo. There's no *_windows.go file now. I'll take a look tomorrow.

@yuchanns Could you please give me a chance to try? I would like to try to deep look opendal-go-services this week.

Sure. It's yours:)

Just for remind:

Error: ....\delete.go:58:25: undefined: unix.BytePtrFromString

The respective function in Windows is windows.UTF16PtrFromString. FYI: https://pkg.go.dev/golang.org/x/sys/windows

Maybe you can create a set of util_$OS.go files to implement common functions across multiple platforms.

util_windows.go
util_nix.go

And export PtrFromString.

Error: C:\Users\runneradmin\go\pkg\mod\github.com\apache\opendal-go-services\[email protected]\service.go:60:29: undefined: libopendalZst
# github.com/apache/opendal/bindings/go

Did you use Go Workspace to develop? Please follow the instructions of https://github.com/apache/opendal/tree/main/bindings/go#development.

Go Workspace is essential to development across opendal and opendal-go-services.

During the development of the Go binding, we do not rely on artifacts released by opendal-go-services. Instead, we build the latest artifacts from opendal-go-services within the Go Workspace. This is likely why you encountered the error below: there are currently no releases for Windows platform artifacts.

Error: ..\..\ffi.go:32:28: undefined: purego.Dlopen
Error: ..\..\ffi.go:32:48: undefined: purego.RTLD_LAZY
Error: ..\..\ffi.go:32:65: undefined: purego.RTLD_GLOBAL
Error: ..\..\ffi.go:44:10: undefined: purego.Dlclos

A positive example is that there are no releases for MacOS artifacts, yet the tests still work because Go Workspace newly generates the artifacts.

Hi, @hezhangjian do you have interest to contintue this PR? Or @yuchanns do you want to take over?

I'm willing to.

Thanks @yuchanns for taking this over. I haven’t been able to find the time to continue recently.