Skip to content

Comments

feat(core): support user defined metadata for oss#4881

Merged
Xuanwo merged 4 commits intoapache:mainfrom
meteorgan:user_metadata
Jul 14, 2024
Merged

feat(core): support user defined metadata for oss#4881
Xuanwo merged 4 commits intoapache:mainfrom
meteorgan:user_metadata

Conversation

@meteorgan
Copy link
Contributor

@meteorgan meteorgan commented Jul 11, 2024 •
edited
Loading

part of: #4842

Done:

  • Implement user_metadata for metadata
  • Implement user_metadata for oss

Todo:

  • support blocking operator

@github-actions github-actions bot requested review from Xuanwo and dqhl76 July 11, 2024 14:26
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 11, 2024
meteorgan
meteorgan commented Jul 11, 2024
View reviewed changes
core/src/types/operator/operator_futures.rs
Copy link
Contributor Author

@meteorgan meteorgan Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function comments in FutureWrite and other related structs are not unified and confusing.
for example:

  1. Set the append mode of op
  2. Set the content type of option
  3. Set the executor for this operation

Is the op, option, operation the same meaning ? shall we unify them ?

Copy link
Member

@Xuanwo Xuanwo Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are the same. We can call them option. We can start a new PR for this.

Xuanwo
Xuanwo reviewed Jul 11, 2024
View reviewed changes
meteorgan
meteorgan commented Jul 11, 2024
View reviewed changes
@Xuanwo Xuanwo changed the title feat(user_metadata): support user defined metadata for oss feat(core): support user defined metadata for oss Jul 11, 2024
meteorgan
meteorgan commented Jul 12, 2024
View reviewed changes
@meteorgan
Copy link
Contributor Author

meteorgan commented Jul 14, 2024

part of: #4842

Done:

  • Implement user_metadata for metadata
  • Implement user_metadata for oss

Todo:

  • support blocking operator

Currently, none of the services that support blocking operations require user metadata. So, it seems there’s no need to support user metadata for the blocking operator, right? @Xuanwo

@Xuanwo
Copy link
Member

Xuanwo commented Jul 14, 2024

Currently, none of the services that support blocking operations require user metadata. So, it seems there’s no need to support user metadata for the blocking operator, right? @Xuanwo

I'm fine to split user metadata support of blocking operations into other PRs. Or just leave them not implemented.

Xuanwo
Xuanwo approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks!

@Xuanwo Xuanwo marked this pull request as ready for review July 14, 2024 14:23
@Xuanwo Xuanwo merged commit b9f7c21 into apache:main Jul 14, 2024
@meteorgan meteorgan deleted the user_metadata branch July 15, 2024 13:30
Lzzzzzt pushed a commit to Lzzzzzt/opendal that referenced this pull request Jul 16, 2024
@meteorgan @Lzzzzzt
feat(core): support user defined metadata for oss (apache#4881)
f872ac3 
* feat(user_metadata): support user defined metadata for oss

* fix cargo fmt && doc tests

* Add user metadata key checks for oss && refeactor some code

* remove unused code
@Xuanwo Xuanwo mentioned this pull request Nov 5, 2024
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@dqhl76 dqhl76 Awaiting requested review from dqhl76

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meteorgan @Xuanwo