Skip to content

Comments

feat(services/s3): Add object versioning for S3#4873

Merged
Xuanwo merged 6 commits intoapache:mainfrom
Lzzzzzt:object-versioning-s3
Jul 9, 2024
Merged

feat(services/s3): Add object versioning for S3#4873
Xuanwo merged 6 commits intoapache:mainfrom
Lzzzzzt:object-versioning-s3

Conversation

@Lzzzzzt
Copy link
Contributor

@Lzzzzzt Lzzzzzt commented Jul 9, 2024

This pull request add support of object versioning for S3

Part of #2611

Basically, done the following task

  • change the args of s3_delete_object to receive the version info
  • add versionId param of the url sent (get, head, del) to the s3 server
  • parse version info from head response and add it into metadata

@Lzzzzzt Lzzzzzt requested a review from Xuanwo as a code owner July 9, 2024 04:46
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jul 9, 2024
@github-actions github-actions bot requested review from dqhl76 and silver-ymz July 9, 2024 04:46
@Lzzzzzt Lzzzzzt changed the title feat(core): Add object versioning for S3 feat(services/s3): Add object versioning for S3 Jul 9, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants